-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PackageInfos_ (#3909) #8534
Conversation
Thanks a lot! So, does this intend to fix #3909 completely or partially? Would you be able to come up with a simple test for the functionality? (It's the easiest to copy-paste and tweak an existing |
I'm lost, which changelog should I append my contribution to? |
@blackheaven there's a checklist in the PR template, it has a reference for the changelog process |
Finally |
fea1716
to
4bca375
Compare
Is there anything I can do to help the merge? |
Hi, the impl looks fine and I'm glad this would solve a closure bloat problem in Nixpkgs! My feedback mostly has to do with English and words in general:
|
Thanks for your feedback, I did my best to take them in account, however, if you can highlight my typos, I'd be grateful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
++ "module PackageInfo_* must include it also on the 'autogen-modules' field " | ||
++ "besides 'exposed-modules' and 'other-modules'. This specifies that " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ "module PackageInfo_* must include it also on the 'autogen-modules' field " | |
++ "besides 'exposed-modules' and 'other-modules'. This specifies that " | |
++ "module PackageInfo_* must include it in 'autogen-modules' as well as" | |
++ " 'exposed-modules' and 'other-modules'. This specifies that " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it, but it's a copy-and-paste from Paths_*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha :) The original is what I would consider "European English": used widely among non-native speakers, understandable, but different from what a native speaker would say. I almost considered just leaving it, because I think it's better to say it's dialectical rather than "wrong". Fine either way
Let me know if I can do something to improve this PR, or if I can squash it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@blackheaven: thank you very much. Re squashing the fixup commits, if you set the squash+merge_me label, Mergify is going to squash the PR when merging it (in two days). |
02ab4ba
to
afa7d0b
Compare
Thanks, I did it manually. |
Perfect. Then go ahead and set the ordinary merge_me label. |
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
afa7d0b
to
7c1ce92
Compare
For future reference this feature should have been conditional on cabal-version. See #9331 |
It's a first attempt, I'm open to feedback.
Please include the following checklist in your PR: